This repository was archived by the owner on Dec 27, 2023. It is now read-only.
react-router-6 migration #177
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are all the syntax changes necessary for this PR? |
It's not necessary 👍 |
If you can, I will suggest removing formatting changes to easily focus on what was really changed. Consider adding ESLint/Prettier in another PR. |
|
Regarding the tests, I also don't know why they are failing. Is the example website working well? Did you try to use the V6 version in your code? Maybe we need to re-write the tests, or skip them for now. What do you think? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not finish yet.
4 tests failed.