Fix warnings in several 7-Zip versions #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra fields need to have a 2-byte long size field after type field. Zip64 record in file header did not have this field. Fixes issue barracudanetworks#44 for recent version of 7-Zip: * 18.01 reports OK. * 16.02 still reports Headers Errror.
7-Zip version 16.02 complaints with Headers Error if there is 0xFFFF. Even when Zip64 EOF has the correct value. Fixes barracudanetworks#44 in 7-Zip version 16.02.
Only create Zip64 fields that are really needed. Only create Zip64 block if there is a value that did not fit into 32 bits.
If all values fit into old short EOF fields, skip Zip64.
kolesar-andras
force-pushed
the
44-7-zip-reports-headers-error
branch
from
ddee4b7 to
e5177ab
Compare
frederikbosch
added a commit
to genkgo/archive-stream
that referenced
this pull request
May 7, 2019
czarpino
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44.