Skip to content

Conversation

@shashika05
Copy link
Contributor

@shashika05 shashika05 commented Oct 17, 2025

Issues

  1. The following spec page was generated from this markdown file and there are some inconsistent formatting issues.
  2. "Edit in Github" button in Connector contributor guide page landing into 404 - page not found on github.

Fixes

  1. Add changes in [slug.js] file.
  1. Add changes in connector-contributor-guide.js file.

Checklist

  1. Fix bullet points inside a Note block is not properly formatted.
    Screenshot 2025-10-16 at 22 12 01
  2. Fix code block inside a Note block is not rendered properly.
    Screenshot 2025-10-16 at 22 13 34
  3. Fix bullet points are not formatted properly.
  4. Fix code block is not rendered properly.
    Screenshot 2025-10-16 at 22 14 31
  5. Fix broken link by changing connector-contributor-guide.md file

@shashika05
Copy link
Contributor Author

@sm1990 Here it seems more changes in the code in case of prettier code formatter. Actual changes are made on <ReactMarkdown> component.

@shashika05 shashika05 changed the title Fix formatting issues Fix broken link and formatting issues Oct 20, 2025
@sm1990
Copy link
Contributor

sm1990 commented Oct 20, 2025

Hi @shashika05 ,

Sorry about the delay in reviewing. 1 small comment. The font size in the highlighted sections are 15.3 px and 14px, whereas in other code blocks its 12.25px. Will you be able to fix that?

spec

@shashika05
Copy link
Contributor Author

Hello @sm1990,
Actually it's my bad. Sure I'm on it.

@shashika05
Copy link
Contributor Author

Hi @sm1990, I have fixed that font problem. Can you review that?

@sm1990
Copy link
Contributor

sm1990 commented Oct 23, 2025

Hi @shashika05 ,

Looks like there is a mismatch in spacing in the code blocks. Too much space below the code. I think it occurs because you're loading a <pre class="shiki github-light" ...> inside another <pre class="shiki github-light" ...>.
spec2

@sm1990
Copy link
Contributor

sm1990 commented Oct 24, 2025

@shashika05 ping me when you address the comments above.

@shashika05
Copy link
Contributor Author

@sm1990 sure.

@shashika05
Copy link
Contributor Author

Hello @sm1990,
Seems like mismatch in spacing in the code blocks is fixed. Can you review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants