Rework core Worker client object to not require config #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakogut
force-pushed
the
worker-client
branch
from
2399cb8 to
a314b67
Compare
|
@balena-ci rebase |
ghost
jakogut
force-pushed
the
worker-client
branch
from
d2e0e8b to
b5babd0
Compare
|
@balena-ci rebase |
There was a problem hiding this comment.
LGTM. Thanks @jakogut for your work on this -- Let's hold off merge till client/core move is compelte
The Worker object retrieves the address of the Worker API to communicate with from a config file. Rename the Worker object to WorkerClient, to indicate that it interfaces with the API of the Worker, and add the workerAddress parameter to the constructor. Export a Worker object that inherits from WorkerClient, and sets the workerAddress from a config as before. Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
To maintain existing functionality, we create a new class inheriting from WorkerClient that maintains the previous method of configuration. Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
jakogut
force-pushed
the
worker-client
branch
from
45e6c81 to
735478f
Compare
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to facilitate creating a Worker client object without a config file, add a parameter to the constructor for the workerAddress. Rename the Worker object to WorkerClient to differentiate the interface from the existing Worker, and create a shim object that extends WorkerClient to retain the previous functionality.