add balena-os-in-container worker #519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
jakogut
suggested changes
Nov 12, 2021
| this.dockerProc = exec('dockerd &') | ||
|
|
||
| // pulling from my own branch at the moment - maybe make a PR on that repo to allow for custom builds | ||
| try { |
There was a problem hiding this comment.
Minor tab inconsistency here
Comment on lines
+73
to
+75
| if (signal != null) { | ||
| if (signal === 'SIGTERM' || signal === 'SIGINT') { | ||
| if (this.osProc != null) { |
There was a problem hiding this comment.
This could be squashed to a single conditional
| reports-storage: | ||
| services: | ||
| core: | ||
| privileged: true |
There was a problem hiding this comment.
Is there a reason the core service is being run privileged? This isn't required for the QEMU worker.
| labels: | ||
| share: 'core-storage' | ||
| worker: | ||
| privileged: true |
There was a problem hiding this comment.
Ditto on the worker service
| args: | ||
| - SKIP_INSTALL_BINARY=true | ||
| - INSTALL_DOCKER=true | ||
| pid: 'host' |
There was a problem hiding this comment.
Is it necessary to disable pid namespacing?
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new worker that lets tests run on a balena-os in container device: https://github.com/balena-os/balenaos-in-container
You can use a saved docker image file, such as the ones generated by yocto jenkins jobs (
balena-image.docker) to create a balenaos-in-container for that os version.To run it, you can clone this branch, and run
make container, then you can run the cloud test suite with it (with some modifications, such as commenting out preloading parts, and adding a line to write the config.json this required by the os-in-container tool)Change-type: minor
Signed-off-by: Ryan Cooke [email protected]