Use contrato to evaluate test contracts instead of json schema #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you could define several json schemas for each test that could be used to determine whether or not a test should be ran. For example, you could do this, to make sure a test only ran for devices with HDMI:
This is quite unwieldly to write and is not simple to extend. This PR lets you instead add a contract to a test using our contract syntax, and then uses contrato to evaluate the tests contract and determine whether or not to do the test. This makes it easier to use, and in the future I think it will be quite useful as we extend the use of contracts (e.g os contracts etc)
You can re write the above syntax as: