Exit with failure if WS connection drops before tests are done #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
vipulgupta2048
changed the title
| case 1: return "1 (error)"; // client/lib/index.js#L401 | ||
| case 2: return "2 (test failure)"; // client/lib/index.js#L323 | ||
| case 3: return "3 (test error)"; // client/lib/index.js#L328 | ||
| case 4: return "4 (testbot disconnect)"; // client/lib/index.js#L394 |
|
@balena-ci rebase |
ghost
force-pushed
the
ryan/fix-false-positive
branch
from
44f75a7 to
f69f685
Compare
|
@vipulgupta2048 I think this PR fixes the problem where we get a PASS if we post to the /stop endpoint in core |
This was referenced Jan 19, 2022
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
Signed-off-by: Ryan Cooke [email protected]