Material 7 #242
Material 7 #242
Conversation
myarmolinsky
force-pushed
the
material-7
branch
3 times, most recently
from
d4c3cf8 to
b358c3b
Compare
|
Website deployed to CF Pages, 👀 preview link https://2bf76ff1.balena-design-system.pages.dev |
myarmolinsky
force-pushed
the
material-7
branch
from
b358c3b to
ea405b5
Compare
| "@mui/material": "^6.3.1", | ||
| "@mui/styled-engine-sc": "^6.3.1", | ||
| "@mui/x-data-grid": "^7.23.5", | ||
| "@mui/lab": "7.0.0-beta.14", |
There was a problem hiding this comment.
is it still necessary ? I mean do we still need to keep the beta ?
that was the reson for it: #221
There was a problem hiding this comment.
That PR you linked is not the reason for the beta, it is the reason for the version not having a ^. And I believe we have agreed that it's better practice in general not to have a ^ for beta versions.
The lab package itself is all betas, it only changes major versions aside from that whenever MUI base is bumped. We use the lab package for the Tabs components. As long as those have not graduated to MUI base (or been removed/canceled), we cannot remove the lab package
Change-type: patch
myarmolinsky
force-pushed
the
material-7
branch
4 times, most recently
from
ddc819c to
65f9cb7
Compare
Change-type: patch
myarmolinsky
force-pushed
the
material-7
branch
5 times, most recently
from
c2b2185 to
9f71146
Compare
| const schemaEnumNames: string[] | undefined = findInObject( | ||
| schema, | ||
| 'enumNames', | ||
| 'ui:enumNames', |
There was a problem hiding this comment.
I like that they finally removed enumNames, since it was never properly supported by JSON Schema typing.
However, this new logic won’t work for two reasons:
ui:enumNames should now be passed through the uiSchema, not the schema, something we haven’t updated yet (and, if I recall correctly, RJST doesn’t even support a uiSchema at this point).
The function is currently looking for ui:enumNames inside the schema, where it will never be found. As a result, I’m pretty sure that all enumNames are now broken with this logic
There was a problem hiding this comment.
You're probably right, I have reverted this line
myarmolinsky
force-pushed
the
material-7
branch
2 times, most recently
from
c8806e1 to
acf28f6
Compare
Change-type: patch
Change-type: patch
myarmolinsky
force-pushed
the
material-7
branch
from
acf28f6 to
5b444ad
Compare
Migration guide: https://mui.com/material-ui/migration/upgrade-to-v7
Fibery: https://balena.fibery.io/Work/Project/Update-from-Material-UI-6-to-7-1874