patch: Replace base image with Docker Official base image #52
Conversation
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| @@ -1,11 +1,7 @@ | |||
| # base-image for node on any machine using a template variable, | |||
| # see more about dockerfile templates here: https://www.balena.io/docs/learn/develop/dockerfile/#dockerfile-templates | |||
| # and about balena base images here: https://www.balena.io/docs/reference/base-images/base-images/ | |||
There was a problem hiding this comment.
Can we remove the above 3 comment lines while we are at it @vipulgupta2048 ?
There was a problem hiding this comment.
Wanted to keep this PR as a standalone one to replace only the base image so it can be referenced in the blog post or docs as an example. Did remove these lines later in #53
Replacing balenalib image with Docker Official image
Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]