Skip to content

messages from the server to the client as reactive stream #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

messages from the server to the client as reactive stream #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36a0100
proof of concept using websocket to send log messages
bahmutov Mar 7, 2019
1262049
add xstream library
bahmutov Mar 7, 2019
ffb6bee
more experiments
bahmutov Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
},
"devDependencies": {
"cypress": "3.1.5",
"semantic-release": "15.13.3"
"semantic-release": "15.13.3",
"xstream": "11.10.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion page/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<body>
<h2>simple HTML page</h2>
<p>to be watched by the tests... 3</p>
<p>to be watched by the tests... 2</p>
<script src="app.js"></script>
</body>
38 changes: 38 additions & 0 deletions plugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,44 @@ if (options && typeof options.watch === 'string') {
client.send(text)
}
})

client.onclose = () => {
console.log('client closing connection ✋')
}
client.onerror = e => {
console.error('WS client error', e)
}

const stdoutWrite = process.stdout.write.bind(process.stdout)
process.stdout.write = what => {
if (typeof what === 'string') {
console.error('wrote stdout')
client.send(
JSON.stringify({
command: 'stdout',
message: what
})
)
}
stdoutWrite.call(null, what)
}
// const stderrWrite = process.stderr.write.bind(process.stderr)
// process.stderr.write = what => {
// if (typeof what === 'string') {
// client.send(
// JSON.stringify({
// command: 'stderr',
// message: what
// })
// )
// }
// stderrWrite.call(null, what)
// }

setTimeout(() => {
console.log('first line is %d', 101)
console.error('but there was an error %s', '😡')
}, 1000)
})
} else {
console.log(
Expand Down
100 changes: 81 additions & 19 deletions support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,90 @@
/// <reference types="Cypress" />

import xs from 'xstream'

const ws = new WebSocket('ws://localhost:8765')

const isReloadMessage = data =>
data.command === 'reload' && Cypress._.isString(data.filename)
const isStdoutMessage = data =>
data.command === 'stdout' && Cypress._.isString(data.message)
const isStderrMessage = data =>
data.command === 'stderr' && Cypress._.isString(data.message)
const isLogMessage = data =>
data.command === 'log' && Cypress._.isString(data.message)

beforeEach(() => {
expect(ws.readyState).to.equal(WebSocket.OPEN)
ws.onmessage = ev => {
console.log('message from OS')
console.log(ev)
if (ev.type === 'message' && ev.data) {
try {
const data = JSON.parse(ev.data)
if (data.command === 'reload' && data.filename) {
console.log(
'reloading Cypress because "%s" has changed',
data.filename
)
window.top.document.querySelector('.reporter .restart').click()
}
} catch (e) {
console.error('Could not parse message from plugin')
console.error(e.message)
console.error('original text')
console.error(ev.data)
}

const producer = {
start (listener) {
console.log('starting producer')
ws.onmessage = ev => listener.next(ev)
},
stop () {
console.log('closing web socket')
ws.close()
}
}
const message$ = xs
.create(producer)
.filter(ev => ev.type === 'message' && Cypress._.isString(ev.data))
.map(ev => ev.data)
.map(JSON.parse)

const reload$ = message$.filter(isReloadMessage)
const stdout$ = message$.filter(isStdoutMessage)
const stderr$ = message$.filter(isStderrMessage)

reload$.addListener({
next (data) {
console.log('reloading Cypress because "%s" has changed', data.filename)
window.top.document.querySelector('.reporter .restart').click()
}
// todo: handle errors and completed event
})

stdout$.addListener({
next (data) {
console.log(data.message)
const log = Cypress.log({
name: 'STDOUT',
message: data.message,
consoleProps () {
return {
message: data.message
}
}
})
log.end()
},
error (e) {
console.error(e)
},
complete () {
console.log('log messages completed')
}
})

stderr$.addListener({
next (data) {
console.error(data.message)
const log = Cypress.log({
name: 'STDERR',
message: data.message,
consoleProps () {
return {
message: data.message
}
}
})
log.end()
},
error (e) {
console.error(e)
},
complete () {
console.log('log messages completed')
}
})
})