Skip to content

Conversation

JasleenKaurSethi
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@JasleenKaurSethi JasleenKaurSethi force-pushed the profile-list branch 2 times, most recently from 4238f72 to cbbdf08 Compare August 18, 2025 16:06
Copy link
Contributor

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Still a few more comments / questions from me but I think we're getting pretty close now 🙂

@sd109 sd109 changed the title Add optional GPU user profiles to jupyterhub azimuth-charts Make notebook profiles configurable in jupyterhub-azimuth chart Sep 12, 2025
Copy link
Contributor

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the changes to allow configurable node label matching via Helm values! Looking very close now, just a few more minor comments and suggested documentation / readability improvements.

Copy link
Contributor

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you might have accidentally reverted some of the previously requested changes as part of 1476e61. I've 'unresolved' a few of the previous conversations where I spotted that you'd mistakenly reverted the suggestions but please double check the other previous comments in case you've accidentally reverted any others too.

@JasleenKaurSethi JasleenKaurSethi force-pushed the profile-list branch 3 times, most recently from f7883a8 to 60451f0 Compare October 6, 2025 13:09
Copy link
Contributor

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@sd109 sd109 merged commit 54a06cf into main Oct 6, 2025
3 checks passed
@sd109 sd109 deleted the profile-list branch October 6, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants