-
Notifications
You must be signed in to change notification settings - Fork 3
Make notebook profiles configurable in jupyterhub-azimuth chart #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
4238f72
to
cbbdf08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Still a few more comments / questions from me but I think we're getting pretty close now 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the changes to allow configurable node label matching via Helm values! Looking very close now, just a few more minor comments and suggested documentation / readability improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you might have accidentally reverted some of the previously requested changes as part of 1476e61. I've 'unresolved' a few of the previous conversations where I spotted that you'd mistakenly reverted the suggestions but please double check the other previous comments in case you've accidentally reverted any others too.
f7883a8
to
60451f0
Compare
d65d101
to
12fc643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
No description provided.