-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: modular commands/services/settings, workspace split, logging & UX polish (v1.0.0) #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.0
Are you sure you want to change the base?
refactor: modular commands/services/settings, workspace split, logging & UX polish (v1.0.0) #54
Conversation
…streamline file storage implementation
…ct directory handling
…tings module to use them
…ined logging initialization
…entialsProvider and ClientFactory traits
…tore for file-based settings management
…r handling in commands module
…implified imports
…n in the transfer command
azerpas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only starting the review but here's a few things already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably broke some logs during development, as handling them will be the subject of a dedicated pull request. In the meantime, I suggest ignoring them (especially the console logs) and waiting for the command-line interface to stabilize before fixing them 🫡
However, I was asked a question: should this type of logging be handled in the command-line interface or in the API? In my opinion, it makes more sense to handle it at the API level, since it's the result of our API call, and the command-line interface doesn't add any information about it. Furthermore, when we run the API on its own, maintaining this type of logging seems really important ?
|
During development, I noticed that I had broken the |

Why?
What?
1.0.0tokio,anyhow,directories,serde_json,tracing-*,rpasswordand addtracing-appendercommands/,services/,settings/,ux/CredentialsProvider+ClientFactorysettings/split intoconsts.rs,logging.rs,store.rs(KISSSettingsStore+FileSettingsStore)main.rsreduced to: init logger → parseCli→run(cli)accounts,trade order new,transfer: now useAuthServiceconfig: persistsclient_numberviaFileSettingsStorequote: typed args (length: i64,interval: i64), structured loggingux::TextProgressBar(reusable + replaces inline progress)tracing-subscriber+tracing-appender~/.local/share/bourso/bourso-cli/bourso.log)RUST_LOGMain impact?
configflag renamed:--username➜--client-numberquoteargs now numeric (length: i64,interval: i64)~/.config/bourso/bourso-cli/settings.json)~/.local/share/bourso/bourso-cli/bourso.log)AuthService)What next?
src/bourso_api