Rename Eluna to ALE

[Foereaper]

In lieu of the decision made in #289 to rebrand/rename, I have gone ahead and renamed the module to ALE, short for AzerothCore Lua Engine.

Due to the module implementation, some core-side changes are required as well, I will make a PR with these changes to the core repository shortly. Both of these changes will have to be merged somewhat at the same time. I will link the core side PR here once that is up, and vice versa.

[Foereaper]

Core PR can be found here

azerothcore/azerothcore-wotlk#22962

[TheSCREWEDSoftware]

I don't see "ALE" in the dicussion as the new name to be calling this.

[Foereaper]

I don't see any discussion about a new name what so ever, and it has been a month now since the decision to rename was made. The problem, and the reason for the original discussion, still stands and is a continuous problem for both the users of the module and the users of Eluna. Hence, that's the name I went with :)

Maintainers are able to edit this PR, so feel free to choose another name and edit the PR accordingly, but at least I've done the ground work for where edits need to be made. I would appreciate some expediency for this problem.

[TheSCREWEDSoftware]

Multiple names were brought to the table, i don't recall if any was defined, but that renaming the module just for the sack of renaming, when they are better things be added or fixed, makes the urgency of a rename meaningless.

CC @iThorgrim

[Foereaper]

but that renaming the module just for the sack of renaming ... makes the urgency of a rename meaningless.

I think it was very clearly stated and discussed in the original issue why this is both necessary and inherently urgent.

[NixAJ]

Is there some inability for the management of azerothcore to be respectful when it comes to using other people's code, and being able to cooperate with them? If Eluna wants you to change the name, you change the name, end of story.

[TesterWoWDev]

Is there some inability for the management of azerothcore to be respectful when it comes to using other people's code, and being able to cooperate with them? If Eluna wants you to change the name, you change the name, end of story.

This. It was clearly decided by the creator of Eluna in the last PR, it isn't about the sake of renaming, its a choice in ownership.

[TheSCREWEDSoftware]

I think it was very clearly stated and discussed in the original issue why this is both necessary and inherently urgent.

Yes it was indeed, but no statement of any urgency.

The project mod-eluna will be renamed to avoid any ambiguity and to clearly mark the difference from the official Eluna project.

Is there some inability for the management of azerothcore to be respectful when it comes to using other people's code, and being able to cooperate with them? If Eluna wants you to change the name, you change the name, end of story.

Opening a PR with the intend of changing the name all of sudden has nothing to do with the inability of managament If Eluna wants you to change the name, you change the name, end of story where was this asked? I see the PR for a rename.

If it's foe or someone else who's the owner of eluna, he/she/they whateever, matter of asking not doing it, no has denied the rename of the fork of eluna.

And if the matter was that urgent and important to the creator(s) of eluna, is matter of talking to one of three people. Either Thorgrium as his the main eluna maintaners on the AC side or talk with Shin or Yehonal directly.

[TheSCREWEDSoftware]

You're free to continue giving actual feedback or opnion to this PR or eluna itself that don't envolve you being disrespectful.

[TesterWoWDev]

So you don't see thorgim and Foe and Shin on that referenced PR? They are all well aware of the expectation from the discussion and no actions were made after the fact.

[Foereaper]

Yes it was indeed, but no statement of any urgency.

I think the fact that the discussion had to be had and a decision reached at all speaks to the urgency of the resolution. This is actively impacting users of both projects. I want that solved, and I think it would be in the best interest of AC for it to be solved as well.

Opening a PR with the intend of changing the name all of sudden has nothing to do with the inability of managament

I agree, opening the PR wasn't inherently to reflect on inability of management, but rather due to lack of progress in solving the issue. If I see no progress, then I might as well do it myself. I think this is reasonable. If the name is not to the liking, then the PRs exist and maintainers can edit them swiftly with the name of your choice.

... where was this asked?

This was the resolution that AC chose to the original issue; either rename/rebrand or conform to the parent project. Since a rename was chosen and I am fine with that resolution, I would like for it to happen for the greater good of both of our user bases.

If it's foe or someone else who's the owner of eluna, he/she/they whateever, matter of asking not doing it

I am indeed the maintainer of the Eluna project. I refer back to the 2nd point in this comment.

And if the matter was that urgent and important to the creator(s) of eluna, is matter of talking to one of three people.

That has been done, both through private channels and through the original issue, both before and after its creation. Due to seemingly no progress, I refer back to the 2nd point in this comment.

[TheSCREWEDSoftware]

Don't quote me fully on this Foe and only @iThorgrim can confirm it. I think is: https://github.com/EclipseLuaEngine/mod-eclipse which i will assume is supposed to be the re-branded / own path of eluna.

I will also ping @Yehonal and @FrancescoBorzi to be brought attention for urgency on the matter in the matter of being resolved, as you agree with the resolution (and i think the link above is the resolution).

[jackpoz]

I approve this PR, as a member of the ancestor project ArcEmu that Eluna is based on (although ALE clashes with the existing ArcEmu Lua Engine name)

[Foereaper]

I approve this PR, as a memer of the ancestor project ArcEmu that Eluna is based on (although ALE clashes with the existing ArcEmu Lua Engine name)

There's enough ALE to go around for everyone 🍻

[AnchyDev]

I approve this PR, as a member of planet earth and the land down under.

[Helias]

@Foereaper thank you very much for your PR. We are currently in the process of selecting a new name for the project and ALE is being considered. Sorry that it is taking too long but as you can imagine we are quite busy with many things. We will get back on this.