Skip to content

Inherit mesos-slave attributes #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 135 commits into
base: master
Choose a base branch
from
Open

Inherit mesos-slave attributes #154

wants to merge 135 commits into from

Conversation

unakatsuo
Copy link
Contributor

/etc/mesos-slave/attributes and /etc/openvdc/executor.toml are having duplicate configuration items.

  • hypervisor
  • openvdc-node-id

This PR removes duplications from executor.toml and retrieve the attributes above from mesos-slave.

b0r6 added 30 commits February 23, 2017 13:49
@unakatsuo unakatsuo requested a review from b0r6 April 10, 2017 10:02
@Metallion
Copy link
Contributor

Why keep a png of docs/diagrams/crash-recovery.png when we have a svg of the same illustration? I think using png in git should be avoided because it's inefficient. Every time the illustration changes, a new copy of the whole file (which is rather large) will be added in git. An svg can just place the lines that changed.

Other than that i'm waiting for a review from @b0r6 and for the merge conflict to be resolved. ^_^

@unakatsuo
Copy link
Contributor Author

Someone was discussing that .svg is not rendered in GH Markdown. It supports raster image format only.

https://github.com/axsh/openvdc/blob/acceptance-test-ovs-executor/ci/citest/acceptance-test/README.md

@Metallion
Copy link
Contributor

I know about it not being rendered in GH markdown but does it need to be in this case? i imagine the docs folder will be used to generate a static site, probably using mkdocs like we do for Wakame-vdc and OpenVNet.

@Metallion
Copy link
Contributor

Still waiting for a review from @b0r6 and either the removal of that png or an answer to my comment about the docs folder. :)

@b0r6
Copy link
Contributor

b0r6 commented Apr 28, 2017

+1

Though it contains the crash-recovery branch, right? Which hasn't been merged yet due to that missing test that I plan to write soon.

@Metallion
Copy link
Contributor

Oh right... I actually hadn't realized that yet. 😮 Thanks. :) In that case we still need to get that tested first, indeed.

b0r6 and others added 21 commits April 28, 2017 15:03
# Conflicts:
#	cmd/openvdc-executor/main.go
#	cmd/openvdc-executor/sshd.go
#	hypervisor/lxc/lxc.go
#	hypervisor/types.go
#	model/model.pb.go
# Conflicts:
#	cmd/openvdc-executor/main.go
#	hypervisor/lxc/lxc.go
#	hypervisor/types.go
#	model/model.pb.go
# Conflicts:
#	ci/citest/acceptance-test/multibox/10.0.100.14-vdc-executor-lxc/guestroot/etc/mesos-slave/attributes
#	model/model.pb.go
#	registry/bindata_assetfs.go
#	scheduler/mesos.go
This reverts commit d7c74f4.
logrus/syslog module blocks the build on non-Linux platforms.
# Conflicts:
#	cmd/openvdc-executor/main.go
#	model/model.pb.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants