-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(bcm-pricing-calculator): Add Billing and Cost Management Pricing… #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… Calculator workload estimate insights
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1486 +/- ##
==========================================
+ Coverage 89.46% 89.50% +0.03%
==========================================
Files 724 725 +1
Lines 50966 51174 +208
Branches 8145 8193 +48
==========================================
+ Hits 45596 45801 +205
- Misses 3459 3461 +2
- Partials 1911 1912 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have reviewed the missed code coverage lines and think those are expected. |
| ) | ||
|
|
||
| # Handle pagination using shared utility | ||
| if max_pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Why does the LLM send this parameter? My suggestion is to actually push all request through paginate_aws_response. The max_pages should the be more of a configuration variable rather than dynamic input from the LLM.
… Calculator workload estimate insights
Fixes
Summary
Changes
Testing
uv run --frozen pytest --cov --cov-branch --cov-report=term-missing. Found no regression in coverage. Unit tests pass. New code files are at 99% code coveragepre-commithookUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? N
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.