Skip to content

Bugfix- isNonNegative and isPositive checks #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix- isNonNegative and isPositive checks #573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a15890
Update Check.scala
SagarMoghe Aug 21, 2024
8a10177
Merge pull request #1 from SagarMoghe/SagarMoghe-patch-1
SagarMoghe Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/scala/com/amazon/deequ/checks/Check.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ case class Check(
satisfies(
// coalescing column to not count NULL values as non-compliant
// NOTE: cast to DECIMAL(20, 10) is needed to handle scientific notations
s"COALESCE(CAST($column AS DECIMAL(20,10)), 0.0) >= 0",
s"COALESCE(CAST('$column' AS DECIMAL(20,10)), 0.0) >= 0",
s"$column is non-negative",
assertion,
hint = hint,
Expand All @@ -1014,7 +1014,7 @@ case class Check(
// coalescing column to not count NULL values as non-compliant
// NOTE: cast to DECIMAL(20, 10) is needed to handle scientific notations
satisfies(
s"COALESCE(CAST($column AS DECIMAL(20,10)), 1.0) > 0",
s"COALESCE(CAST('$column' AS DECIMAL(20,10)), 1.0) > 0",
s"$column is positive",
assertion,
hint,
Expand Down