Skip to content

Conversation

@rmak-cpi
Copy link

@rmak-cpi rmak-cpi commented Jan 3, 2024

Issue: #108

Description: Set session.Options.SharedConfigState to session.SharedConfigEnable to enable aws sso support.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@trondhindenes
Copy link

this really needs to get merged. We're building from the PR branch for the time being.

@nomeelnoj
Copy link

@trondhindenes did you get the custom build working with Docker? Running the custom build via binary seems to work, but on the scratch docker image it does not, and I still get the same error. If I change the docker image to something like ubuntu:latest it works, so I am guessing there is some hidden utility that SSO requires that is not present in scratch. If you have figured it out with scratch, I would love to know if I am just missing something obvious.

@trondhindenes
Copy link

hm I think we just built it locally I'm afraid. Didn't have any problems with that.

@trondhindenes
Copy link

trondhindenes commented Mar 4, 2025

tbh this repo seems more or less abandoned to me, such an important feature as this being just left pending is simply nuts. Maybe it would make sense to semi-officially fork it since AWS doesn't seem to be willing to maintain it.

@eugene-yao-zocdoc
Copy link

@nomeelnoj I had to switch to ubuntu for it to work. I imagine it has something to do with the platform; I'm on arm

@trondhindenes
Copy link

@nomeelnoj I had to switch to ubuntu for it to work. I imagine it has something to do with the platform; I'm on arm

we use it just fine on both ubuntu and macos arm

@trondhindenes
Copy link

@rapphil any chance to get this PR merged?

@FlorinAsavoaie
Copy link

@rohang98 maybe you could help? I noticed you did maintenance on the Admission Controller for this. Could we get some help merging this PR and a couple of others, some minimum maintenance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants