-
Notifications
You must be signed in to change notification settings - Fork 115
Enable AWS SSO support #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
this really needs to get merged. We're building from the PR branch for the time being. |
79cdc4f to
4005155
Compare
4005155 to
ce68bd3
Compare
|
@trondhindenes did you get the custom build working with Docker? Running the custom build via binary seems to work, but on the scratch docker image it does not, and I still get the same error. If I change the docker image to something like |
|
hm I think we just built it locally I'm afraid. Didn't have any problems with that. |
|
tbh this repo seems more or less abandoned to me, such an important feature as this being just left pending is simply nuts. Maybe it would make sense to semi-officially fork it since AWS doesn't seem to be willing to maintain it. |
|
@nomeelnoj I had to switch to ubuntu for it to work. I imagine it has something to do with the platform; I'm on arm |
we use it just fine on both ubuntu and macos arm |
|
@rapphil any chance to get this PR merged? |
|
@rohang98 maybe you could help? I noticed you did maintenance on the Admission Controller for this. Could we get some help merging this PR and a couple of others, some minimum maintenance? |
Issue: #108
Description: Set session.Options.SharedConfigState to session.SharedConfigEnable to enable aws sso support.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.