Skip to content

Enabling TLS 1.3 on Windows #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enabling TLS 1.3 on Windows #732

wants to merge 2 commits into from

Conversation

sfod
Copy link
Contributor

@sfod sfod commented May 21, 2025

Issue #, if available:

Another attempt to support TLS 1.3 on Windows platform.
Previous PR #676 didn't handle older Windows SDKs, so we had to revert it.

Description of changes:

Support TLS 1.3 on Windows when mTLS is used.

Other changes:

  • Use persistent key container for RSA keys.
  • Implement local TLS server for tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (689dee3) to head (4c48cf6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files          30       30           
  Lines        6385     6385           
=======================================
  Hits         5028     5028           
  Misses       1357     1357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfod sfod force-pushed the windows-tls-13 branch from 8cdcc48 to 86575bd Compare May 22, 2025 18:03
@sfod sfod force-pushed the windows-tls-13 branch from ce5ee21 to 4c48cf6 Compare May 22, 2025 20:26
@sfod sfod marked this pull request as ready for review May 22, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants