docs: README syntax highlighting + addTransciever note #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggest alternative option for createOffer Co-Authored-By: Lukas Herman <[email protected]>
sirknightj
changed the title
sirknightj
changed the title
sirknightj
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#50
Description of changes:
Summary: Suggest alternative option for
createOfferonREADME.mdHello, I'm working on project using AWS KinesisVideo, and refered to this repository.
But we encountered some weird issue for a while, and recently recognized that issue was caused by using
createOffer, instead ofaddTransceiver.So at the first time I'd like to suggest replacing
createOffertoaddTransceivertotally on this proejct, but also agreed with PR #50 's opinion ( browser compatibility is depended onadapter.js, not on this project )It may because I'm not fully experienced at developing WebRTC, but it would be helpful for beginners by suggesting there is more latest API syntax and recommend you can choose alternative one if you don't need to care about browser compatibility.
I also checked #PR 50's opinion, and so added @lherman-cs as co-author.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.