Allow using prebuilt libkvscproducer through pkg-config #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hacker1024, thanks for your contribution. We want to avoid breaking backwards compatibility. The behavior we want to make sure doesn't get broken, is that when running In your PR description, could you also add how you tested it (which scenarios/commands you ran)? Finally, could you change the target branch to Looking forward to these enhancements! |
|
Might be related: #1115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
At the moment, the use of
libkvscproducerdoes not respect-DBUILD_DEPENDENCIES. This PR allows it to be found viapkg-configinstead of built from source.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.