Skip to content

Swift: Added example code for text to image generation with Amazon Nova Canvas for Bedrock #7452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Swift: Added example code for text to image generation with Amazon Nova Canvas for Bedrock #7452

wants to merge 36 commits into from

Conversation

monadierickx
Copy link
Contributor

This pull request includes one code example for image generation with Nova Canvas.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Swift This issue relates to the AWS SDK for Swift label May 19, 2025
@sebsto
Copy link

sebsto commented May 19, 2025

I think you need to remove the Llama code from this PR. Start from the main branch. Otherwise looks good, I left a few comments at code level.

sebsto
sebsto suggested changes May 19, 2025
View reviewed changes
Copy link

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions and questions

@DennisTraub DennisTraub self-requested a review May 20, 2025 07:19
DennisTraub
DennisTraub reviewed May 20, 2025
View reviewed changes
.doc_gen/metadata/bedrock-runtime_metadata.yaml Outdated
@@ -423,6 +423,14 @@ bedrock-runtime_Converse_MetaLlama:
- description: Send a text message to Meta Llama, using Bedrock's Converse API.
snippet_tags:
- javascript.v3.bedrock-runtime.Converse_MetaLlama
Swift:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears to be carried over from PR #7434. Could you please remove it to keep PRs isolated? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this!

DennisTraub
DennisTraub reviewed May 20, 2025
View reviewed changes
.doc_gen/metadata/bedrock-runtime_metadata.yaml Outdated
@@ -708,6 +716,14 @@ bedrock-runtime_ConverseStream_MetaLlama:
- description: Send a text message to Meta Llama, using Bedrock's Converse API and process the response stream in real-time.
snippet_tags:
- javascript.v3.bedrock-runtime.ConverseStream_MetaLlama
Swift:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, please remove.

DennisTraub
DennisTraub requested changes May 20, 2025
View reviewed changes
Copy link
Contributor

@DennisTraub DennisTraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes in this PR appear to be carried over from PR #7434. Please remove these unrelated modifications to maintain isolated PRs. Thanks!

swift/example_code/bedrock-runtime/models/meta_llama/Package.swift Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried over from #7434. Please remove.

swift/example_code/bedrock-runtime/models/meta_llama/Sources/Converse/main.swift Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried over from #7434. Please remove.

swift/example_code/bedrock-runtime/models/meta_llama/Sources/ConverseStream/main.swift Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried over from #7434. Please remove.

@monadierickx monadierickx requested a review from DennisTraub May 22, 2025 11:59
@sebsto
Copy link

sebsto commented Jun 5, 2025

@DennisTraub can you review this version and help to move it forward ?

shepazon and others added 13 commits June 16, 2025 14:37
@shepazon @monadierickx
Fix SoS tags for example for Swift (awsdocs#7436)
b786a5b 
Fix SoS tags
@DennisTraub @monadierickx
Swift: Bedrock-Runtime Readme - add custom prerequisite (awsdocs#7453)
c76da74 
Add model access prerequisite to Swift readme
@Laren-AWS @monadierickx
Update to latest tools release 2025.18.3. (awsdocs#7441)
bb4abbc
@DennisTraub @monadierickx
Bedrock Runtime: Remove explicit references to Llama 3 (awsdocs#7444)
806c4e3
@dependabot @monadierickx
Bump aws-cdk-lib from 2.189.0 to 2.189.1 in /resources/cdk/cognito_sc…
b5e51f0 
…enario_user_pool_with_mfa (awsdocs#7454)

Bump aws-cdk-lib in /resources/cdk/cognito_scenario_user_pool_with_mfa

Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.189.0 to 2.189.1.
- [Release notes](https://github.com/aws/aws-cdk/releases)
- [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md)
- [Commits](https://github.com/aws/aws-cdk/commits/v2.189.1/packages/aws-cdk-lib)

---
updated-dependencies:
- dependency-name: aws-cdk-lib
  dependency-version: 2.189.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@DennisTraub @monadierickx
Python: Bedrock Runtime document understanding examples (awsdocs#7446)
e38cc77
@Laren-AWS @monadierickx
Update to latest tools release 2025.20.1 (awsdocs#7457)
a8cd3c8
@martin-conur @monadierickx
Update README.md - fixing bedrock runtime crate link (awsdocs#7461)
90be677
@Laren-AWS @monadierickx
Update to latest tools release 2025.1.0 (awsdocs#7463)
e5b1a12
@tkhill-AWS @monadierickx
Java V2: add existing hard-coded example for the SQS extended client (a…
17cd139 
…wsdocs#7455)

* SqsExtendedClientExample added
@scmacdon @monadierickx
Java V2 added SES example that shows new header information (awsdocs#…
e3a68b1 
…7430)

added the new header example
@DennisTraub @monadierickx
PHP: Add example for Amazon Nova text models, remove example for Jura…
9d586ae 
…ssic-2 (awsdocs#7445)

* Add .local config

* Add Nova Text PHP example

* Remove PHP examples for Jurassic-2 (deprecated)

* Regenerate docs

* Revert add .gitattributes

* Fix formatting
@Laren-AWS @monadierickx
Update to latest tools release 2025.21.1. (awsdocs#7464)
caa1de9
dependabot bot and others added 5 commits June 16, 2025 14:37
@dependabot @monadierickx
Bump com.fasterxml.jackson.core:jackson-core from 2.12.5 to 2.13.0 in…
64acdd2 
… /javav2/example_code/lookoutvision (awsdocs#7475)

Bump com.fasterxml.jackson.core:jackson-core

Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.12.5 to 2.13.0.
- [Commits](FasterXML/jackson-core@jackson-core-2.12.5...jackson-core-2.13.0)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-version: 2.13.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @monadierickx
Bump requests from 2.31.0 to 2.32.4 in /python/example_code/bedrock-a…
c35f02d 
…gent (awsdocs#7477)

Bump requests in /python/example_code/bedrock-agent

Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.31.0...v2.32.4)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @monadierickx
Bump requests from 2.32.0 to 2.32.4 in /.tools (awsdocs#7478)
dc304fc 
Bumps [requests](https://github.com/psf/requests) from 2.32.0 to 2.32.4.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.0...v2.32.4)

---
updated-dependencies:
- dependency-name: requests
  dependency-version: 2.32.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@scmacdon @monadierickx
Fixed a minor bug by updating a SOS tag in the EC2 Yaml file (awsdocs…
57501a2 
…#7476)
@brmur @monadierickx
Fix description in JS scenario (awsdocs#7481)
b8af3f5
@github-actions github-actions bot added DotNet-v3 This issue relates to the AWS SDK for .NET V3 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Kotlin This issue relates to the AWS SDK for Kotlin PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) CDK Relates to the AWS Cloud Development Kit (CDK) Java-v2 This issue relates to the AWS SDK for Java V2 GitHub settings This affects GitHub settings Tools This issue relates to a custom tooling to streamline development tasks labels Jun 16, 2025
@monadierickx monadierickx marked this pull request as ready for review June 16, 2025 12:39
@github-actions github-actions bot removed DotNet-v3 This issue relates to the AWS SDK for .NET V3 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Kotlin This issue relates to the AWS SDK for Kotlin PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) CDK Relates to the AWS Cloud Development Kit (CDK) Java-v2 This issue relates to the AWS SDK for Java V2 GitHub settings This affects GitHub settings Tools This issue relates to a custom tooling to streamline development tasks labels Jun 16, 2025
@sebsto
Copy link

sebsto commented Jun 16, 2025

@DennisTraub I think @monadierickx did the required changes. Can you review ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebsto sebsto sebsto requested changes

@DennisTraub DennisTraub Awaiting requested review from DennisTraub

Requested changes must be addressed to merge this pull request.

Assignees

@shepazon shepazon

Labels
Swift This issue relates to the AWS SDK for Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@monadierickx @sebsto @DennisTraub @shepazon @Laren-AWS @martin-conur @tkhill-AWS @scmacdon @brmur