-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(lambda): correcting changeset detection #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
ae9ffa3
to
7fe099f
Compare
Do you mind providing PR links to any related changes or bug issues for context? |
It's interesting that this is a bug, but it's not related to an issue we discussed offline. So I don't know exactly what this will do (because this only affects SAM's integration tests, and nothing else). |
@valerena do you a link/sim to the issue we discussed offline? |
Issue #, if available
Description of changes
With the updates to the parameter values, the changes were not reflected when the changeSet got created, the issue was with the condition used to check if the update is being made.
Previously, the code used
type == "Update"
to validate if the action was an update, but it should have beenchangeset_type == "Update"
.Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.