make directoryrequest a subclass of BaseDownloadRequest #3987
+12
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TransferUtilityDownloadDirectoryRequest class to inherit from BaseDownloadRequest, eliminating code duplication by removing redundant fields that already exist in the base class.
- Converts TransferUtilityDownloadDirectoryRequest from a standalone class to inherit from BaseDownloadRequest
- Removes duplicate field definitions for properties like BucketName, ModifiedSinceDate, UnmodifiedSinceDate, and server-side encryption settings
- Maintains existing functionality while leveraging inheritance for common download request properties
peterrsongg
requested changes
Aug 29, 2025
| /// The <c>UnmodifiedSinceDate</c> property. | ||
| /// </value> | ||
| public DateTime UnmodifiedSinceDate | ||
| { |
There was a problem hiding this comment.
Can you check that the behavior isn't different? In the BaseDownloadRequest I see
https://github.com/aws/aws-sdk-net/blob/main/sdk/src/Services/S3/Custom/Transfer/BaseDownloadRequest.cs#L145-L152
there is some extra logic. Same goes for ModifiedSinceDate
There was a problem hiding this comment.
good catch ill have to double check this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TransferDownloadDirectoryRequest currently has fields which are already located in BaseDownloadRequest. This change makes TransferDownloadDirectoryRequest extend BaseDownloadRequest so that we dont have to duplicate fields.
In the next PR, we will be adding more common fields to BaseDownloadRequest (in order to comply with having all of the required s3 fields in our high level Transfer Utility Request). To make it easier to review I am separating the changes into multiple PRs (this PR and future PRs)
Motivation and Context
DOTNET-8277
Testing
dry run - 52990dbb-1153-40cc-aad0-04c8b6c39b70 pass
Screenshots (if appropriate)
Types of changes
Checklist
License