- 
                Notifications
    
You must be signed in to change notification settings  - Fork 951
 
Add business metric support for Sigv4A auth scheme #6489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    joviegas
  
              
              reviewed
              
                  
                    Oct 20, 2025 
                  
              
              
            
            
        
          
                ...es-test/src/test/java/software/amazon/awssdk/services/Sigv4aBusinessMetricUserAgentTest.java
          
            Show resolved
            Hide resolved
        
      Removing print statements Renaming few files
              
                    joviegas
  
              
              reviewed
              
                  
                    Oct 23, 2025 
                  
              
              
            
            
        
          
                ...main/java/software/amazon/awssdk/core/internal/http/pipeline/stages/ApplyUserAgentStage.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    joviegas
  
              
              reviewed
              
                  
                    Oct 25, 2025 
                  
              
              
            
            
        
          
                ...ts/src/test/java/software/amazon/awssdk/services/Sigv4aCrtUnavailableBusinessMetricTest.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    joviegas
  
              
              reviewed
              
                  
                    Oct 25, 2025 
                  
              
              
            
            
        
          
                test/crt-unavailable-tests/src/main/resources/codegen-resources/multiauth/service-2.json
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
          
 | 
    
              
                    joviegas
  
              
              approved these changes
              
                  
                    Oct 25, 2025 
                  
              
              
            
            
| 
           This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.  | 
    
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
      
    no-api-surface-area-change
  Indicate there is no API surface area change and thus API surface area review is not required 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    


Add business metrics tracking support for SIGV4A_SIGNING feature ID to track when an operation called using SigV4a signing.
Motivation and Context
This change implements business metrics tracking for SigV4a signing operations as part of the User Agent 2.1. This enables AWS teams to track adoption of SigV4a signing.
Modifications
Added SIGV4A_SIGNING("S") business metric feature ID to BusinessMetricFeatureId enum
Modified ApplyUserAgentStage to add SigV4a business metrics when aws.auth#sigv4a scheme is selected
Testing
Added BusinessMetricsUserAgentTest to verify User-Agent header contains "S" metric for SigV4a signing operations.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License