Update NVTX trace dimensions as a run-time config to avoid unncessary re-compilation. #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unncessary re-compilation. Signed-off-by: Kyle Kim <[email protected]>
rauteric
approved these changes
Oct 3, 2025
bhasunit
reviewed
Oct 10, 2025
| /* Create nvtx domain */ | ||
| char buf[64]; | ||
| snprintf(buf, 64, "aws-ofi-nccl dev %d_%d", dev_id, i); | ||
| this->nvtx_domain[i] = nvtxDomainCreateA(buf); |
There was a problem hiding this comment.
Are we missing the destruction of this nvtx_domain currently ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Following the previous thread, this PR aims to reduce unnecessary re-compilation by updating NVTX trace dimensions into a run-time config.
Like any other run-time config, it is activated via environment variable with
OFI_NCCLprefix.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.