Skip to content

Create pre-production stage for CI pipeline #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

nhatnghiho
Copy link
Contributor

@nhatnghiho nhatnghiho commented Mar 20, 2025

Issues:

Resolves #CryptoAlg-2983 and #CryptoAlg-2984

Description of changes:

This PR implements steps to deploy to pre-production in the CI pipeline, which will act as template for production deployment later on. The PR also sets up a dev deployment environment for testing purposes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.88%. Comparing base (541547d) to head (fcf3908).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   78.81%   78.88%   +0.07%     
==========================================
  Files         621      621              
  Lines      108431   108613     +182     
  Branches    15399    15413      +14     
==========================================
+ Hits        85462    85684     +222     
+ Misses      22298    22261      -37     
+ Partials      671      668       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nhatnghiho nhatnghiho force-pushed the ci-pipeline branch 2 times, most recently from 267feb5 to b100ece Compare March 20, 2025 22:30
@nhatnghiho nhatnghiho force-pushed the ci-pipeline branch 3 times, most recently from 3f82970 to edbd376 Compare March 26, 2025 16:37
@nhatnghiho nhatnghiho marked this pull request as ready for review March 26, 2025 16:39
@nhatnghiho nhatnghiho requested a review from a team as a code owner March 26, 2025 16:39
@skmcgrail skmcgrail self-requested a review March 26, 2025 20:34
else {}
)

@jsii.member(jsii_name="produceAction")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, is there some functionality missing in the Python CDK? Have we given feedback to them about it

andrewhop
andrewhop previously approved these changes May 16, 2025
skmcgrail
skmcgrail previously approved these changes May 20, 2025
@nhatnghiho nhatnghiho dismissed stale reviews from skmcgrail and andrewhop via 7ad6a6b May 20, 2025 21:52
andrewhop
andrewhop previously approved these changes May 20, 2025
skmcgrail
skmcgrail previously approved these changes May 20, 2025
@nhatnghiho nhatnghiho dismissed stale reviews from skmcgrail and andrewhop via 95c74a0 May 20, 2025 23:42
skmcgrail
skmcgrail previously approved these changes May 20, 2025
andrewhop
andrewhop previously approved these changes May 21, 2025
@nhatnghiho nhatnghiho dismissed stale reviews from andrewhop and skmcgrail via fcf3908 May 21, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants