ML-KEM memory safety #2263
Open
ML-KEM memory safety #2263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
==========================================
+ Coverage 78.81% 78.86% +0.05%
==========================================
Files 621 622 +1
Lines 108431 108664 +233
Branches 15398 15407 +9
==========================================
+ Hits 85462 85700 +238
+ Misses 22299 22294 -5
Partials 670 670 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… memory-safety-ml-kem
… memory-safety-ml-kem
… memory-safety-ml-kem
Merged
hanno-becker
reviewed
Apr 4, 2025
|
Updated to resolve merge conflicts from #2176 (change in how parameters are being used, new functions that were added have length checks too). |
torben-hansen
approved these changes
Apr 15, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds length parameters to ML KEM module to ensure allocated memory for various outputs is sufficient for generated results. Checks that already exist in higher levels for some functions were not removed.
Issues:
Resolves #CryptoAlg-2945
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.