chore(python): examples for keyrings #1914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabhichow
force-pushed
the
imabhichow/python-examples-keyrings
branch
4 times, most recently
from
2c651c2 to
c7a025e
Compare
Examples/runtimes/python/DynamoDBEncryption/src/keyring/kms_rsa_keyring_example.py
Outdated
Show resolved
Hide resolved
Examples/runtimes/python/DynamoDBEncryption/src/keyring/raw_rsa_keyring_example.py
Outdated
Show resolved
Hide resolved
Examples/runtimes/python/DynamoDBEncryption/src/keyring/raw_rsa_keyring_example.py
Outdated
Show resolved
Hide resolved
Examples/runtimes/python/DynamoDBEncryption/src/keyring/raw_rsa_keyring_example.py
Outdated
Show resolved
Hide resolved
Examples/runtimes/python/DynamoDBEncryption/src/scan_error_example.py
Outdated
Show resolved
Hide resolved
| key_id = keystore_create_key(TEST_KEYSTORE_NAME, TEST_LOGICAL_KEYSTORE_NAME, TEST_KEYSTORE_KMS_KEY_ID) | ||
|
|
||
| assert key_id is not None | ||
| # TODO: Cleanup Branch Key Items |
There was a problem hiding this comment.
I see other languages don't do this, nice catch.
I don't think we need to do this, but if you have time, feel free to do it.
There was a problem hiding this comment.
I'll keep this TODO for this PR, I'll try to resolve in my next PR by adding a cleanup method.
There was a problem hiding this comment.
I've updated the PR to add cleanup utility for branch keys
imabhichow
force-pushed
the
imabhichow/python-examples-keyrings
branch
from
6aa9c8c to
00bab8f
Compare
imabhichow
force-pushed
the
imabhichow/python-examples-keyrings
branch
from
00bab8f to
93860fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.