Skip to content

WIP chore(python): examples for client_supplier #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: python-poc
Choose a base branch
from

Conversation

imabhichow
Copy link

Issue #, if available:

Description of changes:

  1. examples for client_supplier

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM -- pending CI being fixed by another PR before approving

Comment on lines +33 to +35
In test environments where assuming the role might fail, we fall back to
creating a standard KMS client for the region without assuming a role.
This ensures examples can run in test environments without proper IAM permissions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants