AWS CLI accessibility improvements #9741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds documentation in the 'Options' section for each parameter that is required. There is now a [required] field in line with the parameter name. This also updates the previously implemented required documentation for nested parameters. Also updates string interpolation to use f-strings in clidocs.py.
Adds parameter for output progress frequency, defaulting to 0 to keep current behavior. Add multiline output control to allow for writing the progress report to a new line.
[v2] Adjust format of table for accessibility
Per user feedback, this change makes the error string more identifiable. It capitalizes "error" in the message and add square brackets around it.
Refactors help rendering classes to further separate rendering. Add config option for help output format to either URL or browser. don't allow setting of base remote url
However, this test seems flaky due to interactions with other tests, possibly from mocking `os.environ`. Skipping for now.
Move the logic to a helper called in ResultPrinter._print_progress.
[v2] Adjust error message for accessibility
[v2] S3 progress indicator frequency
[v2] Web-based help for AWS CLI documentation
Add changelog entries for CLI accessibility improvements
Contributor
|
Recommend adding #9743 to the PR description for complete reference all-in-one-place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This feature branch PR releases the following reviewed PRs:
Description of changes:
Release accessibility changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.