Fix dotfile indexing in knowledge base #2944
Open
+60
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Treat dotfiles as text files instead of unknown file types - Allow common config files (.bashrc, .vimrc, .raprc, etc.) through hidden file filters - Add test cases for dotfile patterns (.bashrc, .vimrc, .raprc, .testrc, etc.) Previously, dotfiles were classified as FileType::Unknown and skipped during directory processing, preventing configuration files from being indexed. This change enables indexing of: - Files ending in 'rc' (.bashrc, .vimrc, .raprc) - Files ending in 'config' (.gitconfig, .npmconfig) - Common dotfiles (.gitignore, .env, .dockerignore) Fixes issue where configuration files showed 0 items after indexing. Tested with .raprc and .testrc files - both now properly index content.
kensave
reviewed
Sep 24, 2025
| // Allow common configuration files | ||
| filename.ends_with("rc") | ||
| || filename.ends_with("config") | ||
| || matches!(filename, ".gitignore" | ".env" | ".dockerignore") |
There was a problem hiding this comment.
Can we make this a CONSTANT so we we can use this collection in both places.
| if let Some(filename) = path.file_name().and_then(|n| n.to_str()) { | ||
| if filename.starts_with('.') { | ||
| // Allow common configuration files | ||
| let is_config_file = filename.ends_with("rc") |
There was a problem hiding this comment.
Constant or utility for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously, dotfiles were classified as FileType::Unknown and skipped during directory processing, preventing configuration files from being indexed.
This change enables indexing of:
Fixes issue where configuration files showed 0 items after indexing.
Tested with .raprc and .testrc files - both now properly index content.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.