fix issues in Llama-3.2 MM tutorial #1084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohithkrn
requested review from
PrashantSaraf,
aws-donkrets,
aws-maens,
aws-rhsoln,
aws-sadaf,
aws-singhada,
awsjoshir,
eshalakhotia,
gsnaws,
hannanjgaws,
jeffhataws,
jluntamazon,
micwade-aws,
musunita,
natemail-aws,
pinak-p,
rgrandhiamzn,
shadis,
sidjoshiaws and
vikas-paliwal-aws
as code owners
aws-clairecz-chenya
approved these changes
Jan 8, 2025
aws-clairecz-chenya
left a comment
aws-clairecz-chenya
left a comment
There was a problem hiding this comment.
Do we plan to update anything related to this feedback "For vllm installation guide, specify link to Setup section in the guide otherwise it’s not very clear what all steps in the guide should be performed"?
aws-maens
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update Llama-3.2 MM tutorial with minor fixes.