Skip to content

Aurl utility deprecation #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richtja
Copy link
Contributor

@richtja richtja commented May 15, 2025

This commit deprecates the aurl utility and removes its usages from avocado code base. It is being deprecated because it doesn't bring much value, and it is easy to use common python utilities instead of it.

This commit deprecates the aurl utility and removes its usages from
avocado code base. It is being deprecated because it doesn't bring much
value, and it is easy to use common python utilities instead of it.

Signed-off-by: Jan Richter <[email protected]>
@richtja richtja requested review from clebergnu and harvey0100 May 15, 2025 15:09
@richtja richtja self-assigned this May 15, 2025
@mr-avocado mr-avocado bot moved this to Review Requested in Default project May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.26%. Comparing base (b4791f3) to head (bbaa79c).

Files with missing lines Patch % Lines
avocado/utils/download.py 66.66% 1 Missing ⚠️
avocado/utils/path.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6160   +/-   ##
=======================================
  Coverage   68.26%   68.26%           
=======================================
  Files         205      205           
  Lines       22306    22310    +4     
=======================================
+ Hits        15227    15230    +3     
- Misses       7079     7080    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richtja
Copy link
Contributor Author

richtja commented May 16, 2025

The Coverage CI failure is a flaky test, and it is not related to this PR.

Copy link
Contributor

@harvey0100 harvey0100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review Requested
Development

Successfully merging this pull request may close these issues.

3 participants