chore: Fix TestGetStakingSigner for pre-release builds #4424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the TestGetStakingSigner unit test to use a non-mainnet network name (Fuji) by default to prevent test failures on pre-release branches that don't support mainnet configurations.
- Removes the unused
viperKeysfield from the test struct - Sets the network name to Fuji instead of relying on mainnet as the default
- Adds constants package import for network name constants
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
michaelkaplan13
force-pushed
the
michaelkaplan13/fix-test-get-staking-signer
branch
from
1f3be0e to
44424bb
Compare
michaelkaplan13
changed the title
StephenButtolph
approved these changes
Oct 20, 2025
rrazvan1
approved these changes
Oct 20, 2025
StephenButtolph
deleted the
michaelkaplan13/fix-test-get-staking-signer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Makes the TestGetStakingSigner unit test cleaner and more robust for pre-releases.
See failure on pre-release branch here: https://github.com/ava-labs/avalanchego/actions/runs/18601415517/job/53040501469
How this works
Sets the UT network name to local.
How this was tested
UT
See success on pre-release branch here: https://github.com/ava-labs/avalanchego/actions/runs/18604733876/job/53051490526?pr=4423
Need to be documented in RELEASES.md?
No.