Skip to content

virtio_fs_support_win_fs: wait some time for 7z.exe up #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

virtio_fs_support_win_fs: wait some time for 7z.exe up #4291

wants to merge 1 commit into from

Conversation

xiagao
Copy link
Contributor

@xiagao xiagao commented Mar 23, 2025

  1. wait virtiofs service start after reboot system
  2. wait for 7zip process up

ID: 3369

@xiagao xiagao force-pushed the bz3369-support-win branch 2 times, most recently from cfacfbc to 5d506cf Compare March 23, 2025 02:37
@xiagao
Copy link
Contributor Author

xiagao commented Mar 23, 2025 •
edited
Loading

Except win11, other guests passed.
(1/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(1/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (347.31 s)
(2/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(2/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (245.66 s)
(3/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(3/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (377.16 s)
(4/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(4/4) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (338.39 s)
(1/1) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(1/1) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (412.42 s)
(1/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(1/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: ERROR: Volume is not ready for io within 60. (478.70 s)
(2/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(2/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (465.05 s)

@xiagao xiagao force-pushed the bz3369-support-win branch 5 times, most recently from 8c524bb to 6cccab0 Compare March 25, 2025 01:32
@xiagao
virtio_fs_support_win_fs: wait some time for 7z.exe up
59373f8 
1. wait virtiofs service start after reboot system
2. wait for 7zip process up

Signed-off-by: Xiaoling Gao <[email protected]>
@xiagao xiagao force-pushed the bz3369-support-win branch from 6cccab0 to 59373f8 Compare March 25, 2025 01:47
@xiagao
Copy link
Contributor Author

xiagao commented Mar 25, 2025

@hellohellenmao Call for your review, Tingting. Thanks.

@hellohellenmao
Copy link
Contributor

@xiagao No other comments from my side, but could I ask why the timeout is set to 60 seconds? Is this an experimentally determined value based on your experience, indicating that the VirtioFS driver typically starts within 60 seconds, and if it doesn’t, it’s unlikely to start at all?

@xiagao
Copy link
Contributor Author

xiagao commented Mar 27, 2025

@xiagao No other comments from my side, but could I ask why the timeout is set to 60 seconds? Is this an experimentally determined value based on your experience, indicating that the VirtioFS driver typically starts within 60 seconds, and if it doesn’t, it’s unlikely to start at all?

Yes, basically it needs some time to start virtiofs service after the session was started.

@hellohellenmao
Copy link
Contributor

LGTM.

@leidwang
Copy link
Contributor

Hi @vivianQizhu Would you please help review and merge this MR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leidwang leidwang leidwang approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiagao @hellohellenmao @leidwang