Skip to content

qemu_guest_agent: Called before the variable is assigned #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qemu_guest_agent: Called before the variable is assigned #4253

wants to merge 1 commit into from

Conversation

6-dehan
Copy link
Contributor

@6-dehan 6-dehan commented Jan 20, 2025 •
edited
Loading

add_line_at_end is called before the {guest_homepath} is assigned.
same as cmd_get_guestkey, cmd_del_key_file.

ID: 3323
Signed-off-by: demeng [email protected]

@6-dehan
Copy link
Contributor Author

6-dehan commented Jan 20, 2025 •
edited
Loading

Hi @leidwang please help to review. thanks
(3/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.root.q35: STARTED
(3/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.root.q35: PASS (61.58 s)
(4/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_root_user.q35: STARTED
(4/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_root_user.q35: PASS (112.34 s)
(5/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: STARTED
(5/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: PASS (138.03 s)
(6/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: STARTED
(6/6) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: PASS (120.24 s)

@6-dehan
qemu_guest_agent: Called before the variable is assigned
5a6b808 
add_line_at_end is called before the {guest_homepath} is
assigned. same as cmd_get_guestkey, cmd_del_key_file.

Signed-off-by: Dehan Meng <[email protected]>
@6-dehan 6-dehan force-pushed the KVMAUTOMA-3323-ssh-hotfix branch from 5a532d1 to 5a6b808 Compare January 20, 2025 13:29
@6-dehan
Copy link
Contributor Author

6-dehan commented Jan 23, 2025

@fbq815 could you please help to re-test that case with this patch? thanks

@fbq815
Copy link
Contributor

fbq815 commented Feb 24, 2025

I've tried and it failed, please check the log in jira task

@6-dehan
Copy link
Contributor Author

6-dehan commented Feb 25, 2025

I've tried and it failed, please check the log in jira task

Your problem is not caused by this patch, the package 'sshpass' wasn't installed successfully.
[stderr] stderr: b'Error: Unable to find a match: sshpass\n'

@fbq815
Copy link
Contributor

fbq815 commented Mar 8, 2025

I've add a new comment in jira ticket, please have a look

@6-dehan
Copy link
Contributor Author

6-dehan commented Mar 10, 2025

I've add a new comment in jira ticket, please have a look

Please refer: #4281 (comment)

fbq815
fbq815 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@fbq815 fbq815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:
qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.root.s390-virtio: PASS (31.30 s)
virtio_serial.gagent_ssh_public_key_injection.non_root_user.s390-virtio: PASS (31.45 s)

@6-dehan
Copy link
Contributor Author

6-dehan commented Mar 20, 2025

@leidwang please review it again when you're free.

@6-dehan
Copy link
Contributor Author

6-dehan commented Mar 21, 2025

@vivianQizhu could you please help to review and merge it?

@leidwang
Copy link
Contributor

@vivianQizhu Maybe we can merge this MR since you have approved it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivianQizhu vivianQizhu vivianQizhu approved these changes

@fbq815 fbq815 fbq815 approved these changes

@leidwang leidwang leidwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@6-dehan @fbq815 @leidwang @vivianQizhu