Add Optimizer Sampler #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhash-er
reviewed
Aug 22, 2024
| self, | ||
| epochs: int, | ||
| is_partial_connection: bool = False, |
There was a problem hiding this comment.
I understand that this is cleaner but it may be difficult to read. I think, we need doctrings over here for better readability of what options are available from this class.
There was a problem hiding this comment.
Agreed. We have to also standardize the parameter naming.
abhash-er
reviewed
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
OneShotOptimizerSamplerclass, which can be used to sample a new optimizer, i.e., Profile.This class is incomplete.
There snippet at the bottom which attempts to sample 100 profiles exists only as a sanity test for this class. The class requires more testing.
Since we don't yet know the scope of the experiments we'll run, we'll deal with these items if and when we decide to have BBO search for the optimizer as one of our experiments.