Skip to content

feat(UI-1551): add Kubernetes integration forms #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

J1za
Copy link
Contributor

@J1za J1za commented May 29, 2025

Description

Add Kubernetes connection in the UI

Linear Ticket

https://linear.app/autokitteh/issue/UI-1551/add-kubernetes-connection-in-the-ui

What type of PR is this? (check all applicable)

  • 💡 (feat) - A new feature (non-breaking change which adds functionality)
  • 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
  • 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
  • 🏎 (perf) - Optimization
  • 📄 (docs) - Documentation - Documentation only changes
  • 📄 (test) - Tests - Adding missing tests or correcting existing tests
  • 🎨 (style) - Styles - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • ⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • ☑️ (chore) - Chores - Other changes that don't modify src or test files
  • ↩️ (revert) - Reverts - Reverts a previous commit(s).

@J1za J1za requested a review from RonenMars May 29, 2025 16:18
@itayd
Copy link
Member

itayd commented May 30, 2025

can you add a screenshot? thanks

<ErrorMessage>{errors.config_file?.message as string}</ErrorMessage>
</div>

<Button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haimzlato should we add additional info, like here:
image

@@ -221,6 +223,11 @@ export const IntegrationsMap: Record<Integrations, IntegrationSelectOption> = {
label: "Microsoft Teams",
value: Integrations.microsoft_teams,
},
kubernetes: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itay – Should this be hidden in certain environments (production, or maybe for specific named customers) using a feature flag, or should we display it to everyone?
Since it doesn’t require special credentials or configuration unlike Zoom, Salesforce, or Linear, I think it makes sense to show it to everyone. Do you agree?

@J1za
Copy link
Contributor Author

J1za commented Jun 3, 2025

can you add a screenshot? thanks

animation

@RonenMars
Copy link
Contributor

RonenMars commented Jun 11, 2025

  1. At this moment, no additional info.
  2. Implement with a feature flag, like other connections (for example Zoom or Linear).
  3. Please rebase.

@J1za J1za force-pushed the vitaly/feat/add-kubernetes-connection branch from 2faf051 to aed4dcd Compare June 11, 2025 10:00
@J1za
Copy link
Contributor Author

J1za commented Jun 11, 2025

  1. At this moment, no additional info.
  2. Implement with a feature flag, like other connections (for example Zoom or Linear).
  3. Please rebase.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants