Skip to content

[DAS 338] - Add user projects api #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Arrotech
Copy link
Contributor

@Arrotech Arrotech commented May 5, 2025

What does this PR do?

Add user projects API

Branch Name?

DAS-338-add-user-projects-api

@tylerwarner33
Copy link
Contributor

tylerwarner33 commented May 5, 2025

Good catch on the multiple user ids @Arrotech! I missed that when going through the documentation but it is clearly listed in the blog post.
image

Would it make more sense to have the user ids named in a way that matches the functionality & is understandable when looking at the function definition, like adminUserId & projectsUserId, or something like that, instead of userId & userId2?

@Arrotech
Copy link
Contributor Author

Arrotech commented May 5, 2025

Thanks, @tylerwarner33. Currently, the SDKs use the format userId, userId2. We'll get back to you with a comprehensive solution. By the way, thank you for the great work with the PR.

@sajith-subramanian
Copy link
Contributor

@Arrotech , @tylerwarner33 , @nishchhaldagar -
User-Id in the header could be named actingUserId - Since it is "the ID of a user on whose behalf the request is acting".
And the other one being simply named userId.

@Arrotech
Copy link
Contributor Author

Arrotech commented May 5, 2025

Thanks @sajith-subramanian , we should then do the same for other instances...This is not the only instance where the userId accours atleast twice. There are other endpoints with more than userId parameters.

@Arrotech
Copy link
Contributor Author

Arrotech commented May 5, 2025

@sajith-subramanian I have updated the userId2 to actingUserId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants