Add ability to change merging behavior at runtime. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the contribution. A like the idea for the functionality. As you can see the tests are failing. They need to execute successfully before I can integrate your pull request. Also the pull request lacks the tests for the functionality you are proposing. |
|
Closing in favor of #5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot seem to find an ability to change the merging behavior on-the-fly at runtime.
It seems cumbersome to go and modify each XML tag in the documents and create/specify the merge attribute "combine.children".
This could be implemented using a merge behavior filter. Proposing this pull for the implementation.