Filter rcloud extensions, take 2 #1609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can only .then() a function, not a promise upgrading bluebird caught this
perhaps a poor name, but the idea is that when we initialize a session, we say what kind of session we need, and only the appropriate extensions are loaded
|
What @s-u and I discussed... a long time ago... was to use the existing
This means e.g. changing if (mode %in% cs.modes) { ## use fork only in modes that require ithttps://github.com/att/rcloud/blob/develop/rcloud.support/R/ocaps.R#L88 to a union operation, etc etc. And removing most of the virulent interface changes in the current PR (yay). |
|
I'll clean this up soon and pass back to @s-u for review. |
gordonwoodhull
added a commit
that referenced
this pull request
Aug 14, 2015
can cause CSS problems, etc. still not the extension-flags feature we want (#1609)
|
This seemed potentially too disruptive for the point release - could have strange effects for third-party extension developers, and we also need to make sure they know about the tags they need for the DESCRIPTION file. For now, we've disabled extensions also for mini.html (see commit above). Hope to fix this up and merge to develop soon for 1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1361.
Currently we are only deactivating rcloud extensions for notebook calls. We should allow each session to specify, when it is initialized, which types of extensions should be loaded.
I have resurrected an old branch for this, which was not stable enough for 1.3. The idea is to have a set of flags in the DESCRIPTION file of each RCloud extension, which say what kinds of functionality the extensions provides. Then, after doing the usual per-instance and per-user filtering, these flags are intersected with the flags specified for session.init.
This is _not ready for merge_, since it introduces an unnecessary extra flag which was changing function signatures and wreaking havoc everywhere. As suggested by @s-u, we already have a flag for this, but that one needs to be upgraded to a vector of flags. So far I've just merged develop into this branch, so that we have an active PR for 1.4.3.