Makes USB examples in Tier 1 BSPs safe and suppresses compiler warnings #941
+711
−337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NOTE: Marking as draft because this depends on a merge of PR #935.
A number of Tier 1 BSP examples that use USB as a serial device emit compiler warnings related to the necessary use of
static mut
. Additionally, some are not used in a safe way.This updates these examples to suppress the warnings and make things safe by accessing the USB device in the main program (i.e. not in the USB polling interrupt) only in crticial sections that disable applicable USB interrupts.
The usability issue with USB in embedded applications is a known issue, and the best solution for these examples was discussed in Matrix.
See the commit log for details about which BSP examples were changed, and not that each BSP crate was changed in a separate commit per the guideline.
Checklist
#[allow]
certain lints where reasonable, but ideally justify those with a short comment.