Re-add GCLK0 for CAN dependencies #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. One could bikeshed that the order of elements in the tuple does not match the one from before the revert but types have changed anyway so probably it is not the big deal. |
|
@rnd-ash - gentle reminder that we need to use conventional commits. I believe we'll also need to manually mark this as a breaking change, since it doesn't seem to detect those in feature-gated APIs. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the changes done in #919, whilst also ensuring that the provided GCLK is EnabledGclk0, rather than potentially any GCLK source like it was prior. The way GCLK0 is provided is the same as in the QSPI rework PR (#926), since both peripherals require proof of GCLK0, so both peripherals should have a consistent way of doing this.
@glaeqen would I be able to ask for your input on this?