-
Notifications
You must be signed in to change notification settings - Fork 159
feat: add OpenID Connect (OIDC) provider #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
larsrickert
wants to merge
7
commits into
atinux:main
Choose a base branch
from
larsrickert:larsrickert/oidc-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+359
−3
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
058514e
feat: add OIDC provider
larsrickert 45810f6
make userinfo endpoint optional
larsrickert 95ff0f5
support passing object for openid config
larsrickert 3d83c52
remove `usePKCE` config
larsrickert 094ca26
update docs
larsrickert 42ac681
support custom parameters
larsrickert f679450
support client secret
larsrickert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
export default defineOAuthOidcEventHandler({ | ||
config: { | ||
scope: ['openid', 'profile', 'email'], | ||
}, | ||
async onSuccess(event, { user }) { | ||
await setUserSession(event, { | ||
user: { | ||
oidc: user.name, | ||
}, | ||
loggedInAt: Date.now(), | ||
}) | ||
|
||
return sendRedirect(event, '/') | ||
}, | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,326 @@ | ||
import type { OAuthConfig } from '#auth-utils' | ||
import { useRuntimeConfig } from '#imports' | ||
import { defu } from 'defu' | ||
import type { H3Event } from 'h3' | ||
import { createError, eventHandler, getQuery, sendRedirect } from 'h3' | ||
import { withQuery } from 'ufo' | ||
import { getOAuthRedirectURL, handleAccessTokenErrorResponse, handleInvalidState, handleMissingConfiguration, handlePkceVerifier, handleState, requestAccessToken } from '../utils' | ||
|
||
export interface OAuthOidcConfig { | ||
/** | ||
* OAuth Client ID | ||
* | ||
* @default process.env.NUXT_OAUTH_OIDC_CLIENT_ID | ||
*/ | ||
clientId?: string | ||
/** | ||
* OAuth Client secret. | ||
* If unset, PKCE will be used where no client secret is needed. | ||
* | ||
* @default process.env.NUXT_OAUTH_OIDC_CLIENT_SECRET | ||
*/ | ||
clientSecret?: string | ||
/** | ||
* OpenID configuration. If a string is passed, it is considered to be the full URL to the OpenID configuration endpoint | ||
* where all required endpoints are listed and fetched from automatically. | ||
* | ||
* Alternatively, an object can be set with the required endpoint URLs. | ||
* | ||
* @default process.env.NUXT_OAUTH_OIDC_OPENID_CONFIG | ||
* @example "https://my-provider.com/.well-known/openid-configuration" | ||
*/ | ||
openidConfig?: string | OIDCConfiguration | ||
/** | ||
* OAuth Scope | ||
* | ||
* @default ['openid'] | ||
* @example ['openid', 'profile', 'email'] | ||
*/ | ||
scope?: string[] | ||
/** | ||
* Redirect URL to to allow overriding for situations like prod failing to determine public hostname | ||
* | ||
* @default process.env.NUXT_OAUTH_OIDC_REDIRECT_URL | ||
*/ | ||
redirectURL?: string | ||
/** | ||
* Additional custom parameters that are passed to the specific endpoint requests. | ||
* Can be used to provide custom (query) parameters. | ||
*/ | ||
parameters?: Partial<Record<'authorization_endpoint' | 'token_endpoint' | 'userinfo_endpoint', object>> | ||
|
||
} | ||
|
||
/** | ||
* Standard OIDC claims. | ||
* | ||
* @see: https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims | ||
*/ | ||
interface OidcUser { | ||
/** | ||
* Subject - Identifier for the End-User at the Issuer. | ||
*/ | ||
sub: string | ||
|
||
/** | ||
* End-User's full name in displayable form including all name parts, | ||
* possibly including titles and suffixes, ordered according to the | ||
* End-User's locale and preferences. | ||
*/ | ||
name?: string | ||
|
||
/** | ||
* Given name(s) or first name(s) of the End-User. Note that in some cultures, | ||
* people can have multiple given names; all can be present, with the names | ||
* being separated by space characters. | ||
*/ | ||
given_name?: string | ||
|
||
/** | ||
* Surname(s) or last name(s) of the End-User. Note that in some cultures, | ||
* people can have multiple family names or no family name; all can be present, | ||
* with the names being separated by space characters. | ||
*/ | ||
family_name?: string | ||
|
||
/** | ||
* Middle name(s) of the End-User. Note that in some cultures, people can have | ||
* multiple middle names; all can be present, with the names being separated by | ||
* space characters. Also note that in some cultures, middle names are not used. | ||
*/ | ||
middle_name?: string | ||
|
||
/** | ||
* Casual name of the End-User that may or may not be the same as the given_name. | ||
* For instance, a nickname value of Mike might be returned alongside a given_name | ||
* value of Michael. | ||
*/ | ||
nickname?: string | ||
|
||
/** | ||
* Shorthand name by which the End-User wishes to be referred to at the RP, such as | ||
* janedoe or j.doe. This value MAY be any valid JSON string including special | ||
* characters such as @, /, or whitespace. The RP MUST NOT rely upon this value | ||
* being unique. | ||
*/ | ||
preferred_username?: string | ||
|
||
/** | ||
* URL of the End-User's profile page. The contents of this Web page SHOULD be | ||
* about the End-User. | ||
*/ | ||
profile?: string | ||
|
||
/** | ||
* URL of the End-User's profile picture. This URL MUST refer to an image file | ||
* (for example, a PNG, JPEG, or GIF image file), rather than to a Web page | ||
* containing an image. Note that this URL SHOULD specifically reference a profile | ||
* photo of the End-User suitable for displaying when describing the End-User, | ||
* rather than an arbitrary photo taken by the End-User. | ||
*/ | ||
picture?: string | ||
|
||
/** | ||
* URL of the End-User's Web page or blog. This Web page SHOULD contain information | ||
* published by the End-User or an organization that the End-User is affiliated with. | ||
*/ | ||
website?: string | ||
|
||
/** | ||
* End-User's preferred e-mail address. Its value MUST conform to the RFC 5322 | ||
* addr-spec syntax. The RP MUST NOT rely upon this value being unique. | ||
*/ | ||
email?: string | ||
|
||
/** | ||
* True if the End-User's e-mail address has been verified; otherwise false. | ||
* When this Claim Value is true, this means that the OP took affirmative steps | ||
* to ensure that this e-mail address was controlled by the End-User at the time | ||
* the verification was performed. The means by which an e-mail address is verified | ||
* is context specific, and dependent upon the trust framework or contractual | ||
* agreements within which the parties are operating. | ||
*/ | ||
email_verified?: boolean | ||
|
||
/** | ||
* End-User's gender. Values defined by this specification are female and male. | ||
* Other values MAY be used when neither of the defined values are applicable. | ||
*/ | ||
gender?: string | ||
|
||
/** | ||
* End-User's birthday, represented as an ISO 8601-1 YYYY-MM-DD format. The year | ||
* MAY be 0000, indicating that it is omitted. To represent only the year, YYYY | ||
* format is allowed. Note that depending on the underlying platform's date related | ||
* function, providing just year can result in varying month and day, so the | ||
* implementers need to take this factor into account to correctly process the dates. | ||
*/ | ||
birthdate?: string | ||
|
||
/** | ||
* String from IANA Time Zone Database representing the End-User's time zone. | ||
* For example, Europe/Paris or America/Los_Angeles. | ||
*/ | ||
zoneinfo?: string | ||
|
||
/** | ||
* End-User's locale, represented as a BCP47 language tag. This is typically an | ||
* ISO 639 Alpha-2 language code in lowercase and an ISO 3166-1 Alpha-2 country | ||
* code in uppercase, separated by a dash. For example, en-US or fr-CA. As a | ||
* compatibility note, some implementations have used an underscore as the separator | ||
* rather than a dash, for example, en_US; Relying Parties MAY choose to accept | ||
* this locale syntax as well. | ||
*/ | ||
locale?: string | ||
|
||
/** | ||
* End-User's preferred telephone number. E.164 is RECOMMENDED as the format of | ||
* this Claim, for example, +1 (555) 555-5555 or +56 (2) 687 2400. If the phone | ||
* number contains an extension, it is RECOMMENDED that the extension be represented | ||
* using the RFC 3966 extension syntax, for example, +1 (555) 555-5555;ext=5678. | ||
*/ | ||
phone_number?: string | ||
|
||
/** | ||
* True if the End-User's phone number has been verified; otherwise false. When | ||
* this Claim Value is true, this means that the OP took affirmative steps to | ||
* ensure that this phone number was controlled by the End-User at the time the | ||
* verification was performed. The means by which a phone number is verified is | ||
* context specific, and dependent upon the trust framework or contractual | ||
* agreements within which the parties are operating. When true, the phone_number | ||
* Claim MUST be in E.164 format and any extensions MUST be represented in RFC 3966 format. | ||
*/ | ||
phone_number_verified?: boolean | ||
|
||
/** | ||
* End-User's preferred postal address. | ||
*/ | ||
address?: AddressClaim | ||
|
||
/** | ||
* Time the End-User's information was last updated. Its value is a JSON number | ||
* representing the number of seconds from 1970-01-01T00:00:00Z as measured in | ||
* UTC until the date/time. | ||
*/ | ||
updated_at?: number | ||
} | ||
|
||
/** | ||
* Address claim structure as defined in OpenID Connect specification | ||
*/ | ||
interface AddressClaim { | ||
/** Full mailing address, formatted for display or use on a mailing label */ | ||
formatted?: string | ||
/** Full street address component, which may include house number, street name, post office box, and multi-line extended street address information */ | ||
street_address?: string | ||
/** City or locality component */ | ||
locality?: string | ||
/** State, province, prefecture, or region component */ | ||
region?: string | ||
/** Zip code or postal code component */ | ||
postal_code?: string | ||
/** Country name component */ | ||
country?: string | ||
} | ||
|
||
interface OidcTokens { | ||
access_token: string | ||
scope: string | ||
token_type: string | ||
} | ||
|
||
interface OIDCConfiguration { | ||
authorization_endpoint: string | ||
token_endpoint: string | ||
userinfo_endpoint?: string | ||
} | ||
|
||
/** | ||
* Event handler for generic OAuth using OIDC and PKCE. | ||
*/ | ||
export function defineOAuthOidcEventHandler<TUser = OidcUser>({ config, onSuccess, onError }: OAuthConfig<OAuthOidcConfig, { user: TUser, tokens: OidcTokens }>) { | ||
return eventHandler(async (event: H3Event) => { | ||
config = defu(config, useRuntimeConfig(event).oauth?.oidc, { | ||
scope: ['openid'], | ||
} satisfies OAuthOidcConfig) | ||
|
||
const query = getQuery<{ code?: string, error?: string, state?: string }>(event) | ||
|
||
if (query.error) { | ||
const error = createError({ | ||
statusCode: 401, | ||
message: `OIDC login failed: ${query.error || 'Unknown error'}`, | ||
data: query, | ||
}) | ||
if (!onError) throw error | ||
return onError(event, error) | ||
} | ||
|
||
if (!config.clientId || !config.openidConfig) { | ||
return handleMissingConfiguration(event, 'oidc', ['clientId', 'openidConfig'], onError) | ||
} | ||
|
||
const oidcConfig = typeof config.openidConfig === 'string' ? await $fetch<OIDCConfiguration>(config.openidConfig) : config.openidConfig | ||
|
||
const redirectURL = config.redirectURL || getOAuthRedirectURL(event) | ||
const state = await handleState(event) | ||
|
||
// if no client secret is provided, we will use PKCE so no client secret is needed | ||
const verifier = !config.clientSecret ? await handlePkceVerifier(event) : undefined | ||
|
||
if (!query.code) { | ||
config.scope = config.scope || [] | ||
|
||
return sendRedirect( | ||
event, | ||
withQuery(oidcConfig.authorization_endpoint, { | ||
client_id: config.clientId, | ||
redirect_uri: redirectURL, | ||
scope: config.scope.join(' '), | ||
state, | ||
response_type: 'code', | ||
code_challenge: verifier?.code_challenge, | ||
code_challenge_method: verifier?.code_challenge_method, | ||
...config.parameters?.authorization_endpoint, | ||
}), | ||
) | ||
} | ||
|
||
if (query.state !== state) { | ||
return handleInvalidState(event, 'oidc', onError) | ||
} | ||
|
||
const tokens = await requestAccessToken<OidcTokens & { error?: unknown }>(oidcConfig.token_endpoint, { | ||
body: { | ||
grant_type: 'authorization_code', | ||
client_id: config.clientId, | ||
client_secret: config.clientSecret, | ||
redirect_uri: redirectURL, | ||
code: query.code, | ||
code_verifier: verifier?.code_verifier, | ||
...config.parameters?.token_endpoint, | ||
}, | ||
}) | ||
|
||
if (tokens.error) { | ||
return handleAccessTokenErrorResponse(event, 'oidc', tokens, onError) | ||
} | ||
|
||
let user = {} as TUser | ||
|
||
// some OIDC providers to not support a userinfo endpoint so we only call it when its defined inside the OIDC config | ||
if (oidcConfig.userinfo_endpoint) { | ||
user = await $fetch<TUser>(oidcConfig.userinfo_endpoint, { | ||
headers: { | ||
Authorization: `${tokens.token_type} ${tokens.access_token}`, | ||
}, | ||
body: config.parameters?.userinfo_endpoint, | ||
}) | ||
} | ||
|
||
return onSuccess(event, { | ||
user, | ||
tokens, | ||
}) | ||
}) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part does not seem to omit itself when a clientSecret is provided, resulting in a 400 Bad Request error when fetching the tokens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 269 the verifier is set to undefined if a client secret is passed so its omitted in this case.
For me using a client secret works as expected 🤔 Which OIDC provider are you using?