-
-
Notifications
You must be signed in to change notification settings - Fork 947
chore: add content with case studies #4486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for asyncapi-website failed.
|
WalkthroughAdds a new YAML configuration file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4486 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4486--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/usecases.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
config/usecases.yaml (1)
105-114
: Normalize content type field values.Adeo (line 108) and HDI Global (line 113) use the type
Use Case
, which differs stylistically from other entries (Video, Slides, Article, Docs, Code). For consistency and downstream parsing, consider renaming to a standard type or documenting the full list of allowed values.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/adopters.yml
(0 hunks)config/usecases.yaml
(1 hunks)
💤 Files with no reviewable changes (1)
- config/adopters.yml
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (2)
config/usecases.yaml (2)
50-59
: Verify duplicate URL for Walmart and eBay.Walmart (line 54) and eBay (line 59) both reference the same YouTube URL:
https://www.youtube.com/watch?v=SxTpGRaNIPo
. Confirm whether this is intentional or a copy-paste error. If incorrect, correct the eBay entry.
1-23
: Approved: Use cases section is well-structured.The use cases are clearly defined with consistent formatting and meaningful descriptions. The governance spelling is now correct.
schwarz: | ||
name: Schwarz Group | ||
description: TODO | ||
type: Video | ||
url: TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete TODO entries before merge.
The Schwarz Group (lines 100–104) and SAP (line 119) entries contain placeholder TODO text. Either fill in the data or remove incomplete entries.
Also applies to: 115-119
🤖 Prompt for AI Agents
In config/usecases.yaml around lines 100–104 and 115–119, the entries for
Schwarz Group and SAP contain placeholder "TODO" values for description and url;
replace the TODOs with accurate description, type, and url information (or
remove the entire incomplete entry) so no placeholder text remains—ensure each
usecase has a proper name, non-empty description, valid type, and a reachable
url, and validate YAML formatting after edits.
WIP DON'T REVIEW YET
TODO:
@Shriya-Chauhan yo, this is the content I promised. I started it during my flight, now polishing
Summary by CodeRabbit