Skip to content

Conversation

sarthakNITT
Copy link

@sarthakNITT sarthakNITT commented Aug 1, 2025

Description

fixed #1829
added compile flag in ./src/commands/generate/fromTemplate.ts
added compile flag in ./src/commands/core/flags/generate/fromTemplate.flags.ts

Copy link

changeset-bot bot commented Aug 1, 2025

🦋 Changeset detected

Latest commit: 69f50fa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 1, 2025

Changeset has been generated for this PR as part of auto-changeset workflow.

Please review the changeset before merging the PR.
---
'@asyncapi/cli': minor
---

feat: add --compile flag support to generate fromTemplate command Issue#1829

- e7b086d: bump modelina-cli #1818
- f1b604c: fixed issue#1829

If you are a maintainer or the author of the PR, you can change the changeset by clicking here

Tip

If you don't want auto-changeset to run on this PR, you can add the label skip-changeset to the PR or remove the changeset and change PR title to something other than fix: or feat:.

Copy link

sonarqubecloud bot commented Aug 1, 2025

@sarthakNITT
Copy link
Author

Hi @AayushSaini101,

Can you please review the pr.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, I'm not a maintainer here, just reported an issue but I can already give you feedback that maintainers will for sure do as well:

  • compile is not an entirely new flag, it should be passed into generator like any other generator option through options
  • you are mixing 2 issues in one PR which is never good. Focus on compile and remove modelina-cli upgrade to a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

Enable --compile for generate fromTemplate command
3 participants