Skip to content

Conversation

@rchojn
Copy link

@rchojn rchojn commented Sep 16, 2025

Description

Upgrade Go version from 1.23 to 1.24 to use the latest stable Go release.

🎟 Issue(s)

Related #1705

🧪 Functional Testing

  • Ran make lint - passes without errors
  • Ran make test - all tests pass
  • Verified golangci-lint works with Go 1.24.1

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link
Contributor

@AmFlint AmFlint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code compiles successully, however, I see there's another place in the config.yml (integration-test job, line 117, which manually installs golang version 1.23.4):

integration-test:
    description: "Run integration tests"
    steps:
      - checkout
      - run:
          name: Install Go
          command: |
            set -e
            cd /tmp
            curl -Lo go.tar.gz https://go.dev/dl/go1.23.4.linux-amd64.tar.gz
            sudo rm -rf /usr/local/go
            sudo tar -C /usr/local -xvf go.tar.gz
            GOROOT=/usr/local/go go version
            echo 'export GOROOT=/usr/local/go' >> $BASH_ENV

Can you update this place as well please ?

@rchojn
Copy link
Author

rchojn commented Sep 17, 2025

@AmFlint done

@rchojn rchojn requested a review from AmFlint September 17, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants