Dump JSON values properly. #1660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshih
requested review from
kushalmalani,
neel-astro,
sunkickr and
vandyliu
as code owners
neel-astro
reviewed
Nov 12, 2024
settings/settings.go
Outdated
| vs = vt | ||
| default: | ||
| // Re-encode complex types as JSON. | ||
| b, _ := json.Marshal(v) |
There was a problem hiding this comment.
can we add error handling here, just to be safe
| const ( | ||
| airflowConnectionList = "airflow connections list -o yaml" | ||
| ariflowPoolsList = "airflow pools list -o yaml" | ||
| airflowPoolsList = "airflow pools list -o yaml" |
There was a problem hiding this comment.
appreciate squashing typos, and leaving the code that much better 🙂
|
@neel-astro Okay I rebased my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dump JSON values properly.
🎟 Issue(s)
Fixes #1311
🧪 Functional Testing
Ran
make test,make lint📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft