Skip to content

stash #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stash #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,21 @@ export default defineConfig({
},
},
}),
// env: {
// validateSecrets: true,
// schema: {
// BETTER_AUTH_SECRET: envField.string({
// context: "server",
// access: "secret",
// })
// }
// }
env: {
validateSecrets: true,
Copy link
Member Author

@alexanderniebuhr alexanderniebuhr Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even without this setting it errors, but then just when hitting the import. Nevertheless, it should work with this option true

schema: {
BETTER_AUTH_SECRET: envField.string({
context: "server",
access: "secret",
}),
GITHUB_CLIENT_SECRET: envField.string({
context: "server",
access: "secret",
}),
GITHUB_CLIENT_ID: envField.string({
context: "server",
access: "public",
})
Comment on lines +105 to +108
Copy link
Member Author

@alexanderniebuhr alexanderniebuhr Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public env var is already configured for you in the default place wrangler.jsonc

}
}
});
1 change: 1 addition & 0 deletions src/lib/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { betterAuth } from 'better-auth';
import { admin, oAuthProxy } from 'better-auth/plugins';
import { D1Dialect } from 'kysely-d1';
import { BETTER_AUTH_SECRET } from 'astro:env/server';

export const auth = (url: string, env: Env) => {
return betterAuth({
Expand Down