upgrade to specutils>2.0 #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the specutils dependency from version 1.0+ to 2.0+ to enable reading more JWST spectra formats. The change involves updating the dependency constraint and replacing all references to the deprecated Spectrum1D class with the new Spectrum class from specutils 2.0.
- Update minimum specutils version requirement from 1.0 to 2.0
- Replace
Spectrum1Dclass references withSpectrumthroughout the codebase - Update documentation and comments to reflect the class name change
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updates minimum specutils dependency from 1.0 to 2.0 |
| docs/index.rst | Updates documentation references from Spectrum1D to Spectrum |
| astrodbkit/tests/test_spectra.py | Updates test mock to use Spectrum instead of Spectrum1D |
| astrodbkit/spectra.py | Updates all code references from Spectrum1D to Spectrum class |
Co-authored-by: Copilot <[email protected]>
|
Looks OK to me, and the tests are all passing. |
dr-rodriguez
approved these changes
Aug 13, 2025
|
Now we need a new release. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to read more JWST spectra.